Conversation
- `ConditionSQLEncoder`:
- `keyToSQL`: added check to throw `ConditionEncodingError` if `keys` is empty.
- Refactored `keyFieldReferenceToSQL` to recursively resolve multi-level key references by walking keys and resolving intermediate tables and relationships.
- Added helper methods `_resolveReferenceField` and `_resolveFinalField` to modularize reference resolution logic.
- `DBSQLAdapter`:
- Introduced `_JoinEntry` typedef to represent SQL JOIN fragments with explicit alias dependencies (`defs` and `refs`).
- Added local extension methods on `List<_JoinEntry>` to perform dependency-aware sorting of JOINs ensuring referenced aliases are resolved before use.
- Refactored JOIN construction logic in SQL query building to:
- Collect JOINs as `_JoinEntry` with defined and referenced aliases.
- Sort JOINs by alias dependencies before concatenation.
- Log a warning if not all JOIN references could be resolved.
- This improves correctness and ordering of JOIN clauses in generated SQL.
- Dependencies:
- Updated `async_extension` from ^1.2.17 to ^1.2.18.
- Updated `build_runner` from ^2.10.4 to ^2.10.5.
gmpassos
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #136 +/- ##
==========================================
+ Coverage 65.11% 65.50% +0.39%
==========================================
Files 62 62
Lines 20954 20966 +12
==========================================
+ Hits 13644 13734 +90
+ Misses 7310 7232 -78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConditionSQLEncoder:keyToSQL: added check to throwConditionEncodingErrorifkeysis empty.keyFieldReferenceToSQLto recursively resolve multi-level key references by walking keys and resolving intermediate tables and relationships._resolveReferenceFieldand_resolveFinalFieldto modularize reference resolution logic.DBSQLAdapter:_JoinEntrytypedef to represent SQL JOIN fragments with explicit alias dependencies (defsandrefs).List<_JoinEntry>to perform dependency-aware sorting of JOINs ensuring referenced aliases are resolved before use._JoinEntrywith defined and referenced aliases.Dependencies:
async_extensionfrom ^1.2.17 to ^1.2.18.build_runnerfrom ^2.10.4 to ^2.10.5.